Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't specify --user-filter or other string-valued args #315

Closed
adobeDan opened this issue Dec 9, 2017 · 0 comments
Closed

Can't specify --user-filter or other string-valued args #315

adobeDan opened this issue Dec 9, 2017 · 0 comments
Assignees
@adobeDan
Labels
bug
Milestone
2.3

Comments

@adobeDan
Copy link
Contributor

adobeDan commented Dec 9, 2017

(found in v2.3rc2)

Something is wrong with the merging of invocation defaults and argument values: specifying --user-filter ".*@ensemble.com" produces:

2017-12-08 16:11:59 27327 CRITICAL main - Bad regular expression in user filter: ['.*@ensemble.com'] reason: cannot concatenate 'str' and 'list' objects
@adobeDan adobeDan self-assigned this Dec 9, 2017
@adobeDan adobeDan added the bug label Dec 9, 2017
@adobeDan adobeDan added this to the 2.3 milestone Dec 9, 2017
@adobeDan adobeDan changed the title Can't specify --user-filter or other string-valued (default empty) args Can't specify --user-filter or other string-valued args Dec 9, 2017
adobeDan added a commit that referenced this issue Dec 9, 2017
@adobeDan
Fix #315: Can't specify --user-filter or other string-valued args
3eeec55 
Turns out I misunderstood the use of nargs=1 in argparse: the default behavior is to consume exactly one value; if you specify nargs=1 then you get the single argument as a list containing the value rather than the value itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adobeDan adobeDan

Labels
bug
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
1 participant
@adobeDan