Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user-sync should work in Python 3 as well as Python 2 #52

Closed
adobeDan opened this issue Mar 3, 2017 · 2 comments
Closed

user-sync should work in Python 3 as well as Python 2 #52

adobeDan opened this issue Mar 3, 2017 · 2 comments
Assignees
@ianmak @adobeDan
Labels
enhancement
Milestone
2.2

Comments

@adobeDan
Copy link
Contributor

adobeDan commented Mar 3, 2017

As Python 2 end-of-life is approaching, we need to port user-sync to Python 3 for customers who are transitioning. As with umapi-client, we should support both Python 2 and 3.
@adobeDan
Copy link
Contributor Author

@ianmak I'd like you to take a shot at this. First look at the sources for the umapi-client, where I did this conversion a while ago. The key is to use the six module, which is a shim layer that maps both the 2.7 and 3.x modules to the same namespace. Then you find all the places where 2.7-isms are used, and you convert them to be the six-compatible version which also run in 3.x. Do some research and then tell me what you think; I think this could be right up your alley.

@ianmak
Copy link
Contributor

ianmak commented Mar 25, 2017

sure thing I will take a shot at this.

@adobeDan adobeDan added this to the 2.2 milestone Jun 13, 2017
@adobeDan adobeDan self-assigned this Jun 13, 2017
adobeDan added a commit that referenced this issue Jun 19, 2017
@adobeDan
finish work on #52 related to string types and character encoding.
4d717bf 
* move to pyldap rather than python-ldap to get py3 compatibility.
* carefully fix all the py2 and py3 CSV stuff to work with all character encodings, on both input and output.
* carefully fix all the ldap connections to use unicode for all input parameters, and only to apply decoding to output bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianmak ianmak

@adobeDan adobeDan

Labels
enhancement
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
2 participants
@ianmak @adobeDan