Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a rule to skip user creation if AdobeID exists with the same email #548

Conversation

bhunut-adobe
Copy link
Collaborator

Added a rule to skip user creation if AdobeID exist with the same email as FederatedID/EnterpriseID
Example of the log output

2019-10-24 15:31:05 56505 WARNING processor - Skipping user creation for: federatedID,kbhunut@adobeccetest.com, - AdobeID already exists with kbhunut@adobeccetest.com

#547

Copy link
Collaborator

@adorton-adobe adorton-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs one minor change.

I'm also curious if you've tested this behavior with users that have a different username and email address (whether or not the username type is email or not). Does that have any impact on the UMAPI behavior we're working around here?

user_sync/rules.py Outdated Show resolved Hide resolved
@bhunut-adobe bhunut-adobe force-pushed the enhancement/check_for_adobeID_before_create branch from 91bb926 to d364dfc Compare November 21, 2019 20:48
@adorton-adobe adorton-adobe added this to the v2.6.0 milestone Apr 2, 2020
@adorton-adobe adorton-adobe merged commit 61f21fd into adobe-apiplatform:v2 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants