Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed python 2.7 #586

Merged
merged 1 commit into from Mar 26, 2020
Merged

Conversation

sdhau
Copy link

@sdhau sdhau commented Mar 13, 2020

removed python 2.7

fixes #592

Copy link
Collaborator

@adorton-adobe adorton-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - just one minor change.

Will you please also create an issue with a quick summary of the work required to fulfill this PR? You can keep it simple e.g.

  • Update CI configs
  • Remove py27 build scripts
  • ... etc

And then update the description of this PR with a new line reading "fixes #XXX" where XXX is the issue number.

@@ -32,8 +32,6 @@
description='Application for synchronizing customer directories with the Adobe Enterprise Admin Console',
classifiers=[
'Development Status :: 5 - Production/Stable',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it can we remove the Python 3.5 tag? Technically it doesn't do anything because we don't publish this project to PyPI, but it is nice to keep it updated for the benefit of developers to hint at which Python versions we support. Our CI builds all target 3.6 only in the 3.X series.

@adorton-adobe
Copy link
Collaborator

@vossen-adobe seeing as how this update overlaps with the work we're doing in build/exe I'm going to go ahead an merge it,

@adorton-adobe adorton-adobe merged commit 3e3f3f7 into adobe-apiplatform:v2 Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Python 2.7
2 participants