Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorPageHandlerImpl does unnecessary (maybe) queries #64

Closed
justinedelson opened this issue Nov 25, 2013 · 0 comments
Closed

ErrorPageHandlerImpl does unnecessary (maybe) queries #64

justinedelson opened this issue Nov 25, 2013 · 0 comments

Comments

@justinedelson
Copy link
Contributor

There are two queries running inside ErrorPageHandlerImpl and I believe both can be eliminated.

The first query is to find all the cases where the errorPages property is defined. This can be done without a query by using an InheritanceValueMap to walk up the resource tree from the parent resource.

The second query is to find a page with the appropriate name within the errors path. This can be done by direct node access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinedelson