validation for post sync #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extra validation for post sync config to cover cases like duplicate module, unknown module, and warning for unused configs.
Inspired by error thrown for config path if you change the config like this:
post_sync:
modules:
- sign_sync1
connectors:
sign_sync1: connector-sign-sync.yml
Prior to this change, it will not treat sign_sync1 as a path key, and will throw a confusing error about path not found. Now, it will throw an unknown module error for sign_sync1 in addition to continuing to throw if there is no connector specified for module.