Fix copyDependencies for deps with a / #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a dependency has a slash, previously it would try to find the package.json in the parent folder (e.g., @reduxjs/ for @reduxjs/toolkit) In some cases, like (@reduxjs/toolkit), there is no such dependency, and it would fail to copy anything at all. In other cases, such as @emotion/core, it would copy more than it needs to because the parent package contains many children packages. This way it copies only the target dependency (and its dependencies)
|
@vespakoen Any chance for you to take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dependency has a slash, previously it would try to find
the package.json in the parent folder (e.g., @reduxjs/ for @reduxjs/toolkit)
In some cases, like (@reduxjs/toolkit), there is no such dependency,
and it would fail to copy anything at all. In other cases, such as
@emotion/core, it would copy more than it needs to because the
parent package contains many children packages.
This way it copies only the target dependency (and its dependencies)