Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect width for character 关 on Serif K #5

Closed
PhantomThief opened this issue Apr 4, 2017 · 6 comments
Closed

Incorrect width for character 关 on Serif K #5

PhantomThief opened this issue Apr 4, 2017 · 6 comments
Assignees

Comments

@PhantomThief
Copy link

compare to Source Han Sans
the character 关 has larger width on Source Han Sans K to Source Han Sans
while, it has wrong width for Serif K comparing to Serif.

screen shot 2017-04-04 at 4 53 56 pm

@jimmymasaru
Copy link

jimmymasaru commented Apr 4, 2017

+1 for this issue because:

  1. 关 and 复 are not used in South Korea so that it doesn't matter which one is used.
  2. It can benefit those Chinese users who also prefer Kangxi Style glyphs because Korean variant is the closest one to Kangxi Style. It could make glyphs more consistent (at least widthwise) since these characters are quite commonly used.

@kenlunde kenlunde added the bug label Apr 4, 2017
@kenlunde
Copy link
Contributor

kenlunde commented Apr 4, 2017

@jimmymasaru is correct that U+5173 关 doesn't correspond to either KS standard, so while I consider this a bug, it is not considered urgent. We did override its glyph for the KR fonts of Source Han Sans to use the CN glyph, uni5173-CN, and that override fell between the proverbial cracks. I made a note to add the override for the first update. It is a simple fix, but because it is not urgent for reasons already explained, it will not trigger an update.

Thank you for noticing and reporting this.

@kenlunde kenlunde self-assigned this Apr 4, 2017
@KrasnayaPloshchad
Copy link

KrasnayaPloshchad commented Apr 10, 2017

The following material can be seen as model:
http://old.pep.com.cn/lsysh/jszx/tbjxzy/tpsc/photo/f/201008/t20100827_800362.htm

@kenlunde
Copy link
Contributor

kenlunde commented Apr 11, 2017

Consolidated with Issue #37.

@KrasnayaPloshchad
Copy link

The following material can be seen as model:
http://old.pep.com.cn/lsysh/jszx/tbjxzy/tpsc/photo/f/201008/t20100827_800362.htm

Also see: https://tinyurl.com/k2hzug8

@kenlunde
Copy link
Contributor

kenlunde commented Apr 12, 2017

The situation for U+5173 关 is no different than Source Han Sans. I simply forgot to override the mapping for the KR CMap resource like I did for that typeface. The JP form is unique in that it is thinner. The form used by CN and TW should not be thin, and although this character is outside the scope of the KR support, meaning not in KS X 1001 or KS X 1002, it is an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants