Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidation of Glyph Correction Suggestions (See Issue #39) #27

Closed
hfhchan opened this issue Apr 8, 2017 · 29 comments
Closed

Consolidation of Glyph Correction Suggestions (See Issue #39) #27

hfhchan opened this issue Apr 8, 2017 · 29 comments

Comments

@hfhchan
Copy link

hfhchan commented Apr 8, 2017

image
The TW glyph for U+4FB9 is in error. The second stroke of the top right hand component should be the shortest.

@hfhchan
Copy link
Author

hfhchan commented Apr 8, 2017

image
The TW glyph for U+58FE is in error. The correct glyph exists but is not mapped.

@hfhchan
Copy link
Author

hfhchan commented Apr 8, 2017

Comment Moved to #29 (comment)

@hfhchan
Copy link
Author

hfhchan commented Apr 8, 2017

Comment Moved to #29 (comment)

@hfhchan
Copy link
Author

hfhchan commented Apr 8, 2017

image

The TW glyph for U+591A does not match what is commonly expected in the region.

Compare with the glyphs in the code charts:
image
In HK/TW, the two 夕 are customarily stacked at a steep angle, while that of CN is usually stacked more or less on top of each other.

For HK/TW, the turning corner of the second stroke should be at about the middle of the fifth stroke, instead of three-fourths. Therefore, TW glyph would be better mapped to the JP/KR glyph instead of the CN glyph.

@hfhchan
Copy link
Author

hfhchan commented Apr 8, 2017

image
The 9th stroke of the TW glyph should be shorter than the 8th and 10th stroke. The phonetic component is 𡈼 (middle stroke shortest) which is distinguished from 壬 in TW locale.

@hfhchan
Copy link
Author

hfhchan commented Apr 9, 2017

image

The CN glyphs of U+6660, U+92EE, U+9BCE are incorrect. The TW glyph of U+92EE is also incorrect.

@hfhchan
Copy link
Author

hfhchan commented Apr 10, 2017

image
U+5015: The second last stroke should be longer than the last stroke in the CN glyph.

@hfhchan
Copy link
Author

hfhchan commented Apr 10, 2017

image

The CN glyph for characters containing "祭" as component are inconsistent. Sometimes they are open (in red) and sometimes they are closed (green). Sometimes they share glyphs with JP (always open), sometimes they do not.

@hfhchan
Copy link
Author

hfhchan commented Apr 10, 2017

image
U+68B1: The second last stroke should be 點 instead of 捺 according to the conventions of PRC and TW.

Attached are the code charts for reference:
image

@kenlunde
Copy link
Contributor

kenlunde commented Apr 11, 2017

The Heavy master of the CN glyphs for the following characters requires adjustment such that the two vertical strokes, the left of which curves to the left, are of uniform weight: U+4F5B 佛, U+602B 怫, U+62C2 拂, U+6C1F 氟, U+6CB8 沸, U+7829 砩, U+7ECB 绋. These characters are common in that all are in GB 2312. The following characters are in GB 2312, but their CN glyphs are not affected: U+5F17 弗, U+72D2 狒, U+8274 艴, and U+8D39 费.

seven-vs-four-cn-glyphs

@kenlunde
Copy link
Contributor

Map U+58F3 to uni58F3-JP in the TW CMap resource per Issue #26.

@kenlunde
Copy link
Contributor

Map U+5BE7 to uni5BE7uE0100-JP in the KR CMap resource per Issue #20.

@kenlunde
Copy link
Contributor

Fix the glyphs uni11ED, uni11ED.tjmo01 through uni11ED.tjmo04 (4), uniD7F5, uniD7F5.tjmo01 through uniD7F5.tjmo04 (4), uniD7F6, and uniD7F6.tjmo01 through uniD7F6.tjmo04 (4) per Issue #6. Fix the glyphs uni1178, uniD7B5, and uniD7B5.vjmo01 per Issue #25. Also to be adjusted are the glyphs uni118C.vjmo01, uni1190.vjmo01, uni1192.vjmo01, and uni1112uni119Euni11D9. 22 glyphs in total.

@kenlunde
Copy link
Contributor

Map U+5553 and U+555F to uni5553uE0101-JP and uni555F-JP, respectively, in the TW CMap resource per Issue #13.

@kenlunde
Copy link
Contributor

Fix the glyphs uni5F73-CN and uni6C11-CN so that they are centered of more balanced within the em-box, and fix the interpolation issue in the JP glyph for U+9B58 (uni9B58-JP; Adobe-Japan1-6 CID+7307) per Issue #11.

@kenlunde
Copy link
Contributor

Map U+5173 to uni5173-CN in the KR CMap resource per Issue #5.

@hfhchan
Copy link
Author

hfhchan commented Apr 11, 2017

image
The CN glyph for U+6AE3 is borderline incorrect...

@kenlunde
Copy link
Contributor

@hfhchan: The placement of the Radical 140 component relative to the Radical 159 component suggests that the CN glyph for U+6AE3 櫣 is technically correct.

@kenlunde
Copy link
Contributor

Fix the glyphs uni5316uE0101-JP (Adobe-Japan1-6 CID+13665) and uni82B1uE0101-JP (Adobe-Japan1-6 CID+13666) per Issue #14.

@lapomme
Copy link

lapomme commented Apr 11, 2017

screen shot 2017-04-11 at 10 46 45

The KR/(JP?) glyph for 屄 should have 八 under 宀, not 儿.

17634338_10209324901179517_8965349634815638949_n

@hfhchan
Copy link
Author

hfhchan commented Apr 11, 2017

image
CID 23598 at U+6C77 belongs at U+3CCA instead:

image
image

@hfhchan
Copy link
Author

hfhchan commented Apr 11, 2017

image

The dot for U+3CDA should touch the left hand 撇.

@acuteaccent
Copy link

acuteaccent commented Apr 11, 2017

uni1140uni1175uni11D9 (ᅀᅵᇙ) and uni114Cuni116Funi11D9 (ᅌᅯᇙ) are wrong. Rieul-yeorinhieuh (ㅭ), not rieul-hieuh (ㅀ).

@kenlunde kenlunde changed the title Consolidation of Glyph Correction Suggestions Consolidation of Glyph Correction Suggestions (TO BE REPLACED) Apr 11, 2017
@kenlunde kenlunde changed the title Consolidation of Glyph Correction Suggestions (TO BE REPLACED) Consolidation of Glyph Correction Suggestions (See Issue #39) Apr 11, 2017
@kenlunde
Copy link
Contributor

Consolidated with Issue #39 (so that I can better track and respond to such issues).

@kenlunde
Copy link
Contributor

@Kevite: With regard to your U+5C44 屄 suggestion, this character is outside the scope of KS X 1001 and KS X 1002, so unless there is an existing glyph that is a better match for KR use, and there is not, no change will be made. However, this glyph is outside the scope of Adobe-Japan1-6, meaning that it is a candidate for removal in order to make room for HK glyphs in Version 2.000. If the glyph is not removed, I made a note to change it glyph to conform to KR conventions.

@acuteaccent
Copy link

@kenlunde: Just get rid of uni5C44-JP. I wonder why uni5C44-JP even exists. Use uni5C44-CN for the Japanese and Korean versions instead, like what you did in Source Han Sans for this character.

@kenlunde
Copy link
Contributor

@acuteaccent: As my previous reply stated, this character is a candidate for removal to make room for HK glyphs (Version 2.000), so the chances of it remaining are slim at best. No glyphs will be removed in Version 1.xxx, but the mappings can be changed to orphan them.

@kenlunde
Copy link
Contributor

@acuteaccent: I received the corrected glyphs from Sandoll's designer last night, and she opted to tweak two additional glyphs that correspond to modern hangul syllables. The CID to glyph name mapping of all four glyphs is below (this is for interpreting the image at the end of this comment):

CID+7257 = uniC625
CID+7537 = uniC73D
CID+13681 = uni1140uni1175uni11D9
CID+13702 = uni114Cuni116Funi11D9

What was tweaked for the glyphs for U+C625 옥 and U+C73D 윽 was the relative size of the ㅇ component.

The glyphs shown below are from the ExtraLight, Medium, and Heavy weights:

shserif-four-corrections

@acuteaccent
Copy link

Confirmed. The new glyphs look nice. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants