Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log everything that is written to STDOUT or STDERR in the logs directory #27

Merged
merged 1 commit into from
Jun 26, 2013

Conversation

DennisKehrig
Copy link
Contributor

One timestamped file and one named "_latest.log" are created. Also, log exceptions in _exceptions.log in addition to the output log files.

This should make reporting bugs easier and more helpful.

@DennisKehrig
Copy link
Contributor Author

I noticed that libs/logger.js can also write to files under some circumstances.

I am not sure to what extent they overlap. My idea was to log everything that is dumped to STDOUT and STDERR, regardless of the source, mostly so I can approach developing and debugging the piped version started by PS pretty much the same way I do with the TCP version: by having a console.

In addition there's of course the _exceptions.log. We should keep that even if we decide to discard the rest.

…ory. One timestamped file and one named "_latest.log" are created. Also, log exceptions in _exceptions.log in addition to the output log files
@joelrbrandt
Copy link
Contributor

@DennisKehrig -- looks good to me, merging.

This won't work for a distributed-with-PS version of Generator, because the app bundle / directory will be signed and will be read-only. We should probably do this a bit differently long term (e.g. photoshop might have some other error log that we can append to). I'll file an issue about this.

joelrbrandt added a commit that referenced this pull request Jun 26, 2013
Log everything that is written to STDOUT or STDERR in the logs directory
@joelrbrandt joelrbrandt merged commit 0f64289 into master Jun 26, 2013
@joelrbrandt joelrbrandt deleted the dk/logging branch June 26, 2013 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants