Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theseus is causing New Button in Brackets inline editor not to function correctly. #48

Closed
RaymondLim opened this issue Feb 10, 2014 · 5 comments
Closed

Theseus is causing New Button in Brackets inline editor not to function correctly. #48

RaymondLim opened this issue Feb 10, 2014 · 5 comments

Comments

@RaymondLim
Copy link

Clicking on new rule button while in the CSS Quick edit, opens and closes the list of stylesheets instantly.

adobe/brackets#6641
@alltom
Copy link
Member

alltom commented Feb 10, 2014

Looking into it now, thank you!

@alltom
Copy link
Member

alltom commented Feb 10, 2014

Ah, I was able to reproduce:

  1. Install Brackets Sprint 36 and Theseus.
  2. Create an HTML file and 2 CSS files.
  3. Start Live Development.
  4. Open Quick Edit on an HTML tag to see the associated CSS rules.
  5. Click the "New Rule" button. Since there are multiple CSS files, this should open a menu so you can select which file you want to create the rule in.

Expected: the menu appears and you can select a file name.

Actual: the menu appears momentarily, but disappears.

If Live Development is not started, the menu works as expected. If Theseus is disabled, the menu works as expected. If Theseus is enabled, but there is no JavaScript on the page, the menu works as expected.

My guess, from the rapidity with which the menu disappears, my guess is that something Theseus does in its update timer causes the menu to lose focus.

@alltom alltom mentioned this issue Feb 10, 2014
Closed
@alltom
Copy link
Member

alltom commented Feb 10, 2014

Ah, I guess it's triggering a resize event? Maybe it's that the call count being modified is changing the size of the editor. Hmm.

@alltom alltom closed this as completed in ee4cc99 Feb 10, 2014
alltom added a commit that referenced this issue Feb 10, 2014
@alltom
don't toggle panel visibility unless necessary (fixes #48)
5be8aeb 
setPanelVisibility(), which is called many times per second as new data arrives
(or doesn't arrive), used to set the panel visibility every time, even if the
value did not change. It seems this resulted in a resize event being triggered,
which caused the CSS quick editor drop-down to disappear (see
adobe/brackets#6641).

Now the current value is read, and the value is only set if it differs from
what we want it to be.
@alltom
Copy link
Member

alltom commented Feb 10, 2014

I just released Theseus 0.4.9 which is the same as 0.4.8, but should fix this issue.

@RaymondLim
Copy link
Author

Thanks for taking care of it right away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alltom @RaymondLim