Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] coding bug in cffread saveDeltaArray() #758

Closed
blueshade7 opened this issue Mar 5, 2019 · 0 comments
Closed

[tx] coding bug in cffread saveDeltaArray() #758

blueshade7 opened this issue Mar 5, 2019 · 0 comments
Assignees

Comments

@blueshade7
Copy link
Contributor

blueshade7 commented Mar 5, 2019

cffread.c line 893 reads:

blendEntry->value = lastValue + (stackEntry->is_int) ? (float)stackEntry->u.int_val : stackEntry->u.real_val;

It should read:

blendEntry->value = lastValue + (stackEntry->is_int ? (float)stackEntry->u.int_val : stackEntry->u.real_val);

Otherwise wrong or garbage values may be parsed out as values of BlueValues etc in a Private dict in a CFF2 variable font.

@miguelsousa miguelsousa self-assigned this Mar 5, 2019
miguelsousa pushed a commit that referenced this issue Mar 6, 2019
miguelsousa pushed a commit that referenced this issue Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants