Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed example in spec #88

Closed
brawer opened this issue Dec 9, 2015 · 1 comment
Closed

Malformed example in spec #88

brawer opened this issue Dec 9, 2015 · 1 comment

Comments

@brawer
Copy link
Contributor

brawer commented Dec 9, 2015

In the OpenType Feature File Specification, example 1 of section 6.h.ii. “Specifying Contextual Positioning with explicit lookup references” seems syntactically malformed:

lookup CNTXT_PAIR_POS {
     position T o -10;
     position T c by -12;
} CNTXT_PAIR_POS;

lookup CNTXT_MARK_TO_BASE {
     position base o 
     position base c 
} CNTXT_MARK_TO_BASE;

feature test {
     substitute T' lookup CNTXT_PAIR_POS [o c]' @ALL_MARKS' lookup CNTXT_MARK_TO_BASE;
} test;

Would it be possible to fix the specification, so that the example is syntactically correct?

@readroberts
Copy link
Contributor

I just pushed the fix for this in v1.1.7 of the file.

brawer added a commit to fonttools/fonttools that referenced this issue Jan 7, 2016
…c v1.17

In earlier versions of the OpenType Feature File Format specification,
the example was mal-formed so we had invented our own test case.
Adobe has kindly fixed the format specification:
adobe-type-tools/afdko#88

This change revealed a bug in the parser where mark classes did
not get recognized as glyph classes; this is now fixed, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants