Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --instance_info option to makeinstancesufo #1577

Merged
merged 2 commits into from Dec 1, 2022

Conversation

frankrolf
Copy link
Member

@frankrolf frankrolf commented Nov 22, 2022

Description

--instance_info outputs an indexed list of all instances found in the .designspace file.

fixes #1115

Also, take advanatge of the proper grammar created by icnt_str in a 2nd message.

Checklist:

  • I have followed the Contribution Guidelines

  • I have added test code and data to prove that my code functions correctly
    (I need help with this)

  • I have verified that new and existing tests pass locally with my changes
    (I need help with this)

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas (should be straightforward)

  • I have made corresponding changes to the documentation (the options are not documented)

`--instance_info` outputs an indexed list of all instances found in the .designspace file.

fixes adobe-type-tools#1115

Also, take advanatge of the proper grammar created by `icnt_str` in a 2nd message.
@miguelsousa
Copy link
Member

@frankrolf looks like you just need to add a space before the ellipsis at {tool}..." in captured.err in two places.

@frankrolf
Copy link
Member Author

@miguelsousa Thanks! :-)

Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit d380b72 into adobe-type-tools:develop Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

makeinstancesufo: preflight mode?
3 participants