Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] revert missing cid fail to warn #1633

Merged
merged 8 commits into from Apr 6, 2023

Conversation

kaydeearts
Copy link
Collaborator

@kaydeearts kaydeearts commented Apr 6, 2023

Description

In #1628 , we made some commits that would deprecate from FAIL to WARN when a glyph did not have a CID defined if it was a CID-keyed UFO. Zachary found some issues with this with some further testing. We'll do this in the near future, just wanted to make a release without this for now.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Collaborator

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaydeearts kaydeearts merged commit 9e0a5d1 into develop Apr 6, 2023
7 checks passed
@kaydeearts kaydeearts deleted the kd-revert-missing-cid-fail-to-warn branch April 6, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants