[buildcff2vf] Don't return zero when input requires compatibilization #1668

josh-hadley · 2023-06-30T22:23:53Z

Description

What the title says. Fixes #1667.

I have followed the Contribution Guidelines
I have ~~added~~ updated test code and data to prove that my code functions correctly
I have verified that new and existing tests pass locally with my changes
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
~~I have made corresponding changes to the documentation~~

- non-zero return when input set requires compatibilization - bump __version__ to 2.0.3

- adjust test to catch Error return from buildcff2vf

frankrolf · 2023-07-01T05:55:09Z

Thank you!

josh-hadley added 2 commits June 30, 2023 14:46

Update buildcff2vf.py

ebb5acc

- non-zero return when input set requires compatibilization - bump __version__ to 2.0.3

Update buildcff2vf_test.py

77c6875

- adjust test to catch Error return from buildcff2vf

josh-hadley requested review from frankrolf and kaydeearts June 30, 2023 22:24

miguelsousa approved these changes Jun 30, 2023

View reviewed changes

josh-hadley merged commit c02a68d into develop Jul 1, 2023
15 checks passed

josh-hadley deleted the jh-buildcff2vf-non-zero-return branch July 1, 2023 00:05