[makeotfexe] port tx subroutinizer to makeotfexe #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsousa
reviewed
Aug 5, 2019
| DAWG using the concatenation of all the charstrings from all the fonts as | ||
| input. Subseqeuntly the completed suffix DAWG is traversed in order to count | ||
| CDAWG using the concatenation of all the charstrings from all the fonts as | ||
| input. Subseqeuntly the completed suffix CDAWG is traversed in order to count |
There was a problem hiding this comment.
Subseqeuntly -> Subsequently
There was a problem hiding this comment.
I fixed that. I'm ignoring the Codacy warnings for now, as I want to keep this code reasonably close to the tx code. If I fix either, I want to fix both. (And yes, ultimately, I'd like to just have one shared library for this, but at least this is a step in that direction.)
cjchapman
force-pushed
the
cjc-port-tx-subroutinizer-to-makeotf
branch
from
854321b
to
e03220e
Compare
blueshade7
reviewed
Aug 6, 2019
|
@blueshade7 That's correct. We use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #331