Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev.group by label #14

Merged
merged 3 commits into from Mar 29, 2022
Merged

Dev.group by label #14

merged 3 commits into from Mar 29, 2022

Conversation

tiberiu44
Copy link
Collaborator

Description

This PR contains the following updates:

  • Added description of group_by operations in the labels
  • Added graceful Elastic Search error handling
  • Added option to skip elastic search push
  • Added sanity check for execution of run_pipeline. Either --output-file must be specified or --no-elastic must be removed

Related Issue

Internal request

Motivation and Context

  • group_by information was missing from the labels, which could result in ambiguous label readings
  • Elastic should not be mandatory for simple pipelines, but the --no-elastic option was the only way we could avoid breaking changes

How Has This Been Tested?

I ran the pipeline several times to see that labels are generated correctly and I manually checked the execution sanity by trying different parameter combinations. Finally, I checked the graceful Elastic Errors by enabling elastic push and stopping my local instance

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [-] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [-] I have added tests to cover my changes.
  • All new and existing tests passed.

@acotaie acotaie merged commit fb6b8dc into main Mar 29, 2022
@tiberiu44 tiberiu44 deleted the dev.group_by_label branch March 29, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants