Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Inliner inlines the generic styles instead of specific one. #63

Closed
priyankpardiwala opened this issue Mar 24, 2022 · 2 comments
Closed

Comments

@priyankpardiwala
Copy link

I have a CSS file that looks something like this

p{
color: red;
}

.cmp-text--regular p{
font-size: 20px; 
color: darkgrey; 
}

Expected Behaviour

The expected behavior for the CSS inliner would be to create style attribute

<div class="cmp-text--regular">
<p style="font-size:20px; color: darkgrey;">This should be dark grey</p>
</div>

Actual Behaviour

<div class="cmp-text--regular">
<p style="font-size:20px; color: red;">This should be dark grey</p>
</div>

Notice that the font color is red instead of darkgrey.

@edoardo-goracci
Copy link
Collaborator

Hello Priyank,
Thank you for your test. I confirm that it is a bug, I am going to fix it.

@edoardo-goracci
Copy link
Collaborator

PR created:

#74

@edoardo-goracci edoardo-goracci moved this from Next to Review in progress in aem-core-email-components Mar 28, 2022
@stein-rockware stein-rockware moved this from Review in progress to Reviewer approved in aem-core-email-components Mar 31, 2022
@stein-rockware stein-rockware moved this from Reviewer approved to Done in aem-core-email-components Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants