Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image, Teaser] Validation inconsistencies in dialog Asset tab #2254

Closed
sozores opened this issue Jul 14, 2022 · 3 comments · Fixed by #2665
Closed

[Image, Teaser] Validation inconsistencies in dialog Asset tab #2254

sozores opened this issue Jul 14, 2022 · 3 comments · Fixed by #2665
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.

Comments

@sozores
Copy link

sozores commented Jul 14, 2022

Bug Report

Current Behavior
With image v3 and teaser v2, I've come up with some inconsistencies during dialog input validation. These are my test cases:

  1. [Image, Teaser] Set up linked page with featured image (or a featured image in current page) but no alternative text is set in the linked page page properties: then setting the alternative text in the corresponding input of the Asset tab of the dialog, does not validate.
  2. [Image] Check input "Don't provide an alternative text" in the Asset tab of the dialog: then the Link input is not visible.

Expected behavior/code
For each test case:

  1. Allow an alternative text to be manually defined by the user
  2. Enable the Link input field even if alternative text is not provided

Environment

  • AEM version and patch level: 2022.6.7904.20220629T070041Z
  • Core Components version: 2.20.4
  • JRE version: OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
@bpauli bpauli added the bug Unexpected problem or unintended behavior that impairs normal functioning of the product. label Aug 5, 2022
@bpauli
Copy link
Contributor

bpauli commented Aug 5, 2022

We need to fix test case 1. I don't think we should provide the link capability for images without alt text for accessibility reasons.

@BrianAva
Copy link

BrianAva commented Aug 5, 2022

And lack of alt text hurts page experience: engines track UX accessibility metrics.
https://www.searchenginejournal.com/google-alt-text-only-a-factor-for-image-search/442865/

@EssersB
Copy link

EssersB commented Aug 18, 2022

We are experiencing similar problems with the teaser and image components.
Steps to reproduce:

  1. Put an image component on a page.
  2. Open the author dialog of the image component.
  3. Deselect the checkbox "Inherit featured image from page".
  4. Drag an image file from the sidebar in the author dialog.
  5. (leave checkbox "Inherit from description of asset" selected)
  6. Select the checkbox "Don’t provide an alternative text".
  7. Try to save the image component (click on "Done") --> It is not possible and the tab asset is marked as incorrect.

The same will happen when trying to save a teaser with an image and both checkboxes selected.

I would expect that if "Don’t provide an alternative text" is selected, it doesn't matter whether "Inherit from description of asset" is selected or not.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants