Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML ID Validation - The validator should not throw error when ID field is empty #2522

Closed
yash5728 opened this issue Jun 6, 2023 · 1 comment · Fixed by #2571
Closed
Milestone

Comments

@yash5728
Copy link

yash5728 commented Jun 6, 2023

Feature Request

Is your feature request related to a problem? Please describe.
For the HTML ID page property uniqueness validation, the validation is executed even when ID field is not authored with a value. Unfortunately, in a scenario where the source html has an empty ID attribute anywhere (not an ideal scenario as id should never be empty), still the validator throws error and properties cannot be saved.

Describe the solution you'd like
Add a check that if current authored value of the id field is empty, return without validation.

Are there alternatives?
N/A

Documentation
If you can, explain how users will be able to use this and possibly write out a version of the docs.
image

@yash5728 yash5728 changed the title HTML ID Validation - The validator should not validate when ID field is empty HTML ID Validation - The validator should not throw error when ID field is empty Jun 16, 2023
@vladbailescu
Copy link
Member

Possibly caused by #2278

@vladbailescu vladbailescu linked a pull request Jan 16, 2024 that will close this issue
@vladbailescu vladbailescu added this to the 2.23.4 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants