Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image] svg handling not working #291

Closed
ogebert opened this issue Sep 20, 2018 · 5 comments
Closed

[Image] svg handling not working #291

ogebert opened this issue Sep 20, 2018 · 5 comments

Comments

@ogebert
Copy link

ogebert commented Sep 20, 2018

Bug Report

Current Behavior
Tests done on http://localhost:4502/editor.html/content/we-retail/language-masters/en/experience.html after adding an image component on the page.
Drag & drop a svg on the image component. The svg is added (it is displayed if I open the component dialog), but not rendered, actually the tag is not rendered at all, instead we have an error in the log:
20.09.2018 14:15:46.016 ERROR [0:0:0:0:0:0:0:1 [1537445746008] GET /content/we-retail/language-masters/en/experience/jcr:content/root/responsivegrid/image.html HTTP/1.1] com.adobe.cq.wcm.core.components.internal.models.v1.ImageImpl Image at /content/we-retail/language-masters/en/experience/jcr:content/root/responsivegrid/image uses binary with a non-supported image mime type (image/svg+xml)

Expected behavior/code
Either the svg should not be droppable or it should be rendered as an .

Environment
vanilla AEM 6.4 SP1 with cq-6.4.0-featurepack-24267-1.0.

Additional context / Screenshots
SVGs can be dropped on the image component, but dropping them in the component dialog does not work - might be another bug.
bildschirmfoto 2018-09-20 um 14 34 13

@jckautzmann
Copy link
Contributor

Thx @ogebert for reporting this issue. Could you please confirm that you're using Core Components 2.1.0 [0]?

[0] https://github.com/Adobe-Marketing-Cloud/aem-core-wcm-components/releases/tag/core.wcm.components.reactor-2.1.0

@ogebert
Copy link
Author

ogebert commented Sep 20, 2018

I was running on the version that came with AEM 6.4 (or SP1) - 2.0.4. After installing 2.1.0, the svg is rendered correctly, drag&drop in the dropzone of the component or directly in the layout container works also fine. Thanks for the hint!
Still, I cannot drag and drop an svg into the component dialog.
Should I open a separate issue for the dropzone problem?

@jckautzmann
Copy link
Contributor

@ogebert Cool that it works now. For the other problem, please create a separate issue with details about which image component you are using (I assume the We.Retail image).

@vladbailescu
Copy link
Member

@ogebert , is this the same issue as #271 (comment) ?

@jckautzmann
Copy link
Contributor

@ogebert I just tested with the following setup and I was able to drag-n-drop an SVG into the edit dialog of the We.Retail Image component:
CQ 6.4 + SP1 + FP-24267 + Core Components 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants