Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Update to ECMAScript Modules #77

Open
ChazUK opened this issue Jan 13, 2022 · 0 comments
Open

[feature] Update to ECMAScript Modules #77

ChazUK opened this issue Jan 13, 2022 · 0 comments

Comments

@ChazUK
Copy link

ChazUK commented Jan 13, 2022

Is your feature request related to a problem? Please describe.
Trying to build a clientlib containing @adobe/aem-spa-page-model-manager produces this error message.

Warning: /Users/uut1/repos/europe-design-system.webapp/apps/eds-aem-clientlib/src/app/components/model-manager.service.ts depends on '@adobe/aem-spa-page-model-manager'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Describe the solution you'd like
@adobe/aem-spa-page-model-manager is compiled to an ECMAScript Module instead of CommonJS so code can be optimised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant