Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move eventIndex in interact response to event error/warning report object #68

Closed
kevinlind opened this issue Jun 20, 2023 · 0 comments · Fixed by #72
Closed

Move eventIndex in interact response to event error/warning report object #68

kevinlind opened this issue Jun 20, 2023 · 0 comments · Fixed by #72
Assignees
@kevinlind
Labels
task Item that can be completed as a standalone code change or is part of an epic.Used by issue template
Milestone
v2.2.0

Comments

@kevinlind
Copy link
Contributor

Task description

Currently the "eventIndex" for event errors and event warnings in the interact response is expected to be a top-level field in an event error/warning object. However, Konductor defines the eventIndex in the "report" object, so Edge is looking in the wrong place for that field.

  • Change NetworkResponseHandler to look for "eventIndex" in the "report" object of the event error and event warning objects.
  • Update test cases accordingly.

Additional implementation details or code snippet(s)

No response
@kevinlind kevinlind added the task Item that can be completed as a standalone code change or is part of an epic.Used by issue template label Jun 20, 2023
@kevinlind kevinlind mentioned this issue Jun 29, 2023
Closed
@kevinlind kevinlind self-assigned this Jul 10, 2023
@kevinlind kevinlind linked a pull request Jul 10, 2023 that will close this issue
Get 'eventIndex' from 'report' object for interact response errors and warnings #72
Merged
10 tasks
@emdobrin emdobrin added this to the v2.2.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinlind kevinlind

Labels
task Item that can be completed as a standalone code change or is part of an epic.Used by issue template
Projects
None yet
Milestone
v2.2.0
2 participants
@emdobrin @kevinlind