Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior for empty target.server configuration setting for Target #72

Closed
swarna04 opened this issue Mar 29, 2021 · 0 comments · Fixed by #75
Closed

Fix behavior for empty target.server configuration setting for Target #72

swarna04 opened this issue Mar 29, 2021 · 0 comments · Fixed by #75
Assignees
@yangyansong-adbe
Labels
coresquad target

Comments

@swarna04
Copy link
Contributor

swarna04 commented Mar 29, 2021 •
edited
Loading

If custom Target server is empty/ not configured, use previously persisted edge host. If not present, fallback to the configured Target client code for the host name in Target requests.

https://github.com/adobe/aepsdk-target-ios/blob/dev/AEPTarget/Sources/Target.swift#L532

if let targetServer = targetServer, !targetServer.isEmpty {...}
@swarna04 swarna04 changed the title Fallback to edge host/ Target client code for host in Target requests Fix behavior for empty target.server configuration setting for Target Mar 29, 2021
@yangyansong-adbe yangyansong-adbe linked a pull request Mar 30, 2021 that will close this issue
Not use empty target server url #75
Merged
@yangyansong-adbe yangyansong-adbe self-assigned this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangyansong-adbe yangyansong-adbe

Labels
coresquad target
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Not use empty target server url
2 participants
@swarna04 @yangyansong-adbe