Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Node.js 16 and 18 support #679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document Node.js 16 and 18 support #679

wants to merge 1 commit into from

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Jun 26, 2023

Build with Node.js 18 as well
This closes #557

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kwin
Document Node.js 16 and 18 support
1085982 
Build with Node.js 18 as well
This closes adobe#557
queeek
queeek approved these changes Feb 13, 2024
View reviewed changes
Copy link

@queeek queeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, doesn't work anymore with 12 and 14, but works fine with 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queeek queeek queeek approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support NodeJS 16 (latest LTS)
2 participants
@kwin @queeek