Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document manifest includes #207

Closed
purplecabbage opened this issue Aug 5, 2020 · 2 comments
Closed

Document manifest includes #207

purplecabbage opened this issue Aug 5, 2020 · 2 comments
Assignees

Comments

@purplecabbage
Copy link
Member

purplecabbage commented Aug 5, 2020

Recent additions [1] to aio-cli-app-plugin allow the use of include in Project Firefly manifest.yml
This same functionality will soon be available in aio-cli-plugin-runtime also. There is no definitive documentation for us to refer to in open-whisk, so we need to clearly document it ourselves for Firefly app developers.

 include:
  - ["actions/my-action/images/*.jpg", "jpegs/"]

[1] adobe/aio-lib-web#124

Some reference info can be found here:
https://medium.com/openwhisk/whisk-deploy-zip-actions-with-include-exclude-30ba6d96ad8b

Openwhisk include zipping code (go) is here:
https://github.com/apache/openwhisk-wskdeploy/blob/cbe7c52d99c1ead5172946d3aeb33adb5d5c40b2/utils/zip.go#L115

Here is a test file with various include permutations:
https://github.com/apache/openwhisk-wskdeploy/blob/8e4a79926039612c5242f06942c3382919acc021/tests/src/integration/zipactionwithinclude/manifest.yml

Openwhisk Issue:
apache/openwhisk-wskdeploy#1107
apache/openwhisk-wskdeploy#991

@meryllblanchet
Copy link
Contributor

I'll work on this one in the Firefly docs.

@meryllblanchet
Copy link
Contributor

Closing in favor of AdobeDocs/app-builder#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants