New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Linux) Add Proxy configuration support #224
Comments
Hi @SwonVIP and thanks for reaching out! Could we ask you a bit more of details?
This is the first time we have a user facing proxy issues and would love to hear more. Note: this should not be the reason for your issue, but fyi |
our teammate @shazron found this -- https://www.serverlab.ca/tutorials/linux/administration-linux/how-to-configure-proxy-on-ubuntu-18-04/ would you like to give it a try? |
aio info
aio app init adaptTo You are about to initialize the project 'adaptTo' @sarahxxu I dont know if it is possible but it would be really nice if the aio would have an available flag to set or configure the proxy somehow. Maybe to even be more system independant - could be useful in certain situations. |
For NTLM, we need to wrap all our service calls with an NTLM handshake. This will have to be a new feature @sarahxxu |
@shazron Thanks for the investigation. Let's put this as an improvement ticket for later! :) |
@sarahxxu , I flagged this one as enhancement request accordingly. |
JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-950 |
Hi @justinedelson , it seems that adobe/aio-cli-plugin-cloudmanager#177 relates to this one. cc @sarahxxu |
@meryllblanchet I absolutely think that the mechanism to set proxy configuration should be consistent across plugins. I honestly don't know enough to say whether the mechanism to use that configuration can be shared easily. For example, So... I hate to say this, but I think what we need is |
@shazron any reason why we opted for @justinedelson adobe/aio-lib-ims#52 hasn't been prioritized yet on our side. cc @sarahxxu |
@meryllblanchet I believe we can move off request-promise since it has been deprecated. Since this was implemented by another developer, there was no cohesiveness of library usage, which we can do now. We are using node-fetch in most of the libraries, and sometimes using cross-fetch (which uses node-fetch behind the scenes). |
Related: adobe/aio-lib-core-networking#13 |
Is proxy support still something that is being worked on? |
@arobsco : this has been implemented for aio. Not sure why this ticket is still open |
Thanks wasn't sure as having issues with the aio-cli app not connecting and only reason I can come up with is it's not honouring proxy settings but I'll do some more digging |
Please reach out to @shazron for implementation details, if needed |
@shazron it looks like this issue isn't fully resolved in that although https://github.com/adobe/aio-lib-core-networking is proxy aware and supports proxies, not all the plugins for AIO CLI use the networking package. For example https://github.com/adobe/aio-lib-console/blob/7ec79a21e83d8d4db6642b8ad6bb84a386a1fb14/src/index.js#L185-L190 uses Swagger API which is not configured to use networking package and therefore have proxy awareness Changing the code to require the networking package and use custom fetch solves the issue at least for the aio-lib-console package |
Expected Behaviour
When using the aio-cli behind a corporate proxy the proxy should be somehow configurable or it should be able to use the environment variables
Actual Behaviour
aio-cli cannot connect to the internet for example to load the project list from AEMaaCS account.
Reproduce Scenario (including but not limited to)
Be behind a corporate proxy like proxy.example:8080 which supports NTLM authentication.
Steps to Reproduce
Launch aio and try to access your AEMaaCS information during the init steps.
Platform and Version
Linux Ubuntu (18.04)
aio-cli:Latest
node/npm: LTS
Sample Code that illustrates the problem
Cant priovide this only had temporary access to a AEMaaCS test account during AdaptTo() 2020
Logs taken while reproducing problem
Connection failed error message
The text was updated successfully, but these errors were encountered: