Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support presignUrls on public files or explicitely throw an error #81

Open
moritzraho opened this issue Dec 9, 2020 · 3 comments
Open
Labels
bug Something isn't working

Comments

@moritzraho
Copy link
Member

moritzraho commented Dec 9, 2020

Expected Behaviour

presignUrls for public files might be useful for handing over write or delete permissions, obviously read is not useful.
we do not support it for now but still don't throw an error, and the user receives a non working presign URL

Actual Behaviour

via TVM credentials:

via BYO credentials:

@moritzraho moritzraho added the bug Something isn't working label Dec 9, 2020
@aiojbot
Copy link
Collaborator

aiojbot commented Dec 9, 2020

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-987

@purplecabbage
Copy link
Member

isn't it easier just to support it? I would just prevent it from throwing an error and move on

@moritzraho
Copy link
Member Author

@purplecabbage yes, it's about generating the presign URL against the public container instead of the private one when the file starts with 'public/' prefix
This needs fixing in two places:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants