Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Limit Configuration #105

Closed
fe-lix- opened this issue Jul 29, 2022 · 1 comment
Closed

Memory Limit Configuration #105

fe-lix- opened this issue Jul 29, 2022 · 1 comment

Comments

@fe-lix-
Copy link
Contributor

fe-lix- commented Jul 29, 2022

Expected Behaviour

When configurating an action memory limit in app.config.yaml as such :

application:
  actions: actions
  web: web-src
  runtimeManifest:
    packages:
      mypackage:
        actions:
          myactions:
            function: actions/myaction.js
            runtime: 'nodejs:14'
            limits:
              memory: 512

The memory limit is not taken into account and the default of 256 is being used.

Actual Behaviour

The memory limit from app.config.yaml should be used.

Platform and Version

All platform, aio-cli:8.3.0, @adobe/aio-cli-plugin-runtime:5.4.0 and @adobe/aio-lib-runtime:4.0.0

Sample Code that illustrates the problem

The problem seems to be here

memory: manifestAction.limits.memorySize || 256,

The documentation one two states everywhere we should be using memory when the code uses memorySize.

@fe-lix-
Copy link
Contributor Author

fe-lix- commented Jul 29, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants