This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Find or Replace in Files crashes Brackets if project has many multi-MB (but < 30 MB) text files #10571
Comments
nethip
changed the title
|
@julieyuan @rawat11 This looks like the same crash as #9362. In the thread the user mentioned that he has some log files that are pretty huge and upon removing them find was working fine. Could you run this script in developer tools console and post your results. You can access developer tools from Debug->Developer Tools menu. After developer tools is open, click on the console tab and paste the following code. This should report list of files in the project that are more than 1MB. |
|
@nethip That shouldn't be a problem anymore, since Brackets no longer opens text files > 30 MB or so. But I'd be interested in the output of the code above anyway, if @julieyuan can try it -- just in case. |
|
@nethip @peterflynn Thanks, per the instructions, here are the large files. the build I used is Release 1.2 build 1.2.0-15689 (master 97c3a4c). |
|
Ok, in that case this does appear to be closely related to #9362 -- V8 is running out of memory because of all the file contents we've read. In the original bug is was one super-huge file, in this bug it's many medium-huge files adding up. This will be trickier to fix. Some options off the top of my head:
|
|
Btw, @julieyuan from the log above it appears you're opening your entire user folder ( I'm actually surprised you didn't hit the 30,000-file limit. What's the output if you just run this? |
|
@peterflynn the output in console is: |
|
Ah, so it's getting pretty close to the limit already. I did the math and even with the 16 MB file size cutoff, there's a total of 4.6 GB of files that Brackets would try to read. (Some are binary and would get rejected, but the huge number of .log files are certainly text data and those would get read & cached). |
peterflynn
added
medium priority
F File System
F Find and Replace
and removed
Mac only
labels
peterflynn
changed the title
peterflynn
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps:
Result:
After a few minutes, Brackets crashes
Expected:
It should pop up the error message with large project.
ENV: Mac 10.9 ENU OS
Build: 1.2.0-15675
Notes:
Not sure whether related to bug #9362 or not.
Please refer to the Screenshots and bug log below:
The text was updated successfully, but these errors were encountered: