Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Lost undo history after save #10845

Closed
fazelmk opened this issue Apr 7, 2015 · 14 comments
Closed

Lost undo history after save #10845

fazelmk opened this issue Apr 7, 2015 · 14 comments

Comments

@fazelmk
Copy link

fazelmk commented Apr 7, 2015

If I save the file I can't undo the last modifications, and I still with the file open.

How to reproduce:

  1. Make some changes
  2. save
  3. try to undo

If the file is not saved the undo works fine

Brackets version: Release 1.2 experimental build 1.2.0-15697 (release 8f82e2a)

@peterflynn
Copy link
Member

@fazelmk Do you have any sort of background process running that might modify the file, or its timestamp, after saving? Also, please try Debug > Reload Without Extensions and see if that makes the problem stop.

@fazelmk
Copy link
Author

fazelmk commented Apr 7, 2015

Without extensions it works.

@peterflynn
Copy link
Member

You can follow these steps to narrow down which extension is causing the problem: https://github.com/adobe/brackets/wiki/Troubleshooting#disabling-extensions-individually

@fazelmk
Copy link
Author

fazelmk commented Apr 7, 2015

Brackets Git is the one that broke the undo function.
Thanks for the help @peterflynn.

@peterflynn
Copy link
Member

@fazelmk Can you file a bug with the extension's author here? I'll close this since it appears not to be a core Brackets bug.

@fazelmk
Copy link
Author

fazelmk commented Apr 9, 2015

Done. And the bug is a change in files timestamp like you said. Caused by the Clear withespace on file save option o brackets-git. If anyone else got this problem. =D

@peterflynn
Copy link
Member

@fazelmk Definitely file a bug then -- there should be a cleaner way for the extension to do that feature without breaking Undo history.

@fazelmk
Copy link
Author

fazelmk commented Apr 9, 2015

I did file a bug report to then using the bug report in the brakets extension. I saw that it was a known bug and I get the option that causes the error from another guy issue report.

@abose
Copy link
Contributor

abose commented Apr 10, 2015

brackets-userland/brackets-git#958 says its a core issue: any external modifications to a file will clear the undo cache.

@pramodkumaar
Copy link

Thank's a lot man.. @peterflynn

@arunroy
Copy link

arunroy commented Feb 8, 2016

I had the same issue with AngularJs extension. I had to disable it to get the undo function working.

@Luk4
Copy link

Luk4 commented Mar 18, 2016

The extension BracketstoIX creates the same issue. Once disabled, undo-after-save works fine.

@apptoix
Copy link

apptoix commented Mar 24, 2016

I have tested the latest version of Brackets (1.6) and BracketstoIX both in Windows and OSX 10, and in both situations the undo was working after save.
Please, provide details on a-bentofreire/bracketstoix#19, in order to determine which conditions exactly generate this issue.
Also, include if you have any operations defined on "After Save" dialog.

@rcosgrave
Copy link

Thank you @peterflynn !!!! I should have known

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants