Selection jiggles while resizing window horizontally #1283

Closed
redmunds opened this Issue Jul 19, 2012 · 8 comments

Comments

Projects
None yet
5 participants
Contributor

redmunds commented Jul 19, 2012

Recipe:

  1. On any page, find/create a line of text with > 60 chars
  2. Select roughly the middle 1/3 of the line of text
  3. Change the width of brackets app

Results:
The painting of the selection highlighting briefly changes with the width of the window (seems to be a percentage of viewport width). It quickly snaps back to the correct size, but there is enough delay to make it very noticeable.

Expected:
Selection highlighting does not change with editor window width

This seems to be caused by recent CodeMirror changes.

Member

peterflynn commented Jul 19, 2012

Definitely a regression from the last CodeMirror merge. Probably same cause as #1267. Marijn has already pushed up a fix for that, so I'll test whether it covers this case too.

@ghost ghost assigned peterflynn Jul 19, 2012

Member

peterflynn commented Jul 19, 2012

Confirmed this is now fixed in CodeMirror upstream -- next sprint's CM merge will give us a fix

Member

pthiess commented Jul 24, 2012

Reviewed thats opened for Sprint 12. Waiting to get the fix in CM.

Member

peterflynn commented Aug 2, 2012

The CodeMirror merge has been deferred to Sprint 13 due to some recent instability in the CM scrolling code. Pushing this bug out till then.

Member

peterflynn commented Aug 21, 2012

This seems much harder to reproduce in brackets-shell, but it's definitely still there (noticeable especially on my older Mac).

@peterflynn peterflynn referenced this issue in adobe/CodeMirror2 Aug 23, 2012

Merged

Fix bugs with selection width #74

Member

njx commented Aug 23, 2012

Turns out the fix in CodeMirror (which we've merged) doesn't fully fix this case, though it does reduce how often it happens. I've filed marijnh/CodeMirror#745 on this, so we can continue to track it. Removing sprint 13.

Member

gruehle commented Sep 20, 2012

This is fixed in CodeMirror v3 branch. See codemirror/CodeMirror@314e7ea

Contributor

redmunds commented Jan 26, 2013

Confirmed that this is fixed in cmv3 branch. Closing.

@redmunds redmunds closed this Jan 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment