Auto-Identation and Switch Statements

[jdiehl]

I noticed that the auto-indentation seems to be confused after switch statements. Consider the following (JSLint-approved) code:

function foo(a) {
    "use strict";
    switch (a) {
    case 1:
        break;
    }
}

When hitting enter after the first closing }, auto-indentation inserts 3 tabs (1 would be correct).
When hitting enter after the second closing }, auto-indentation again inserts 3 tabs (0 would be correct).
This goes on, even if additional functions, scopes, whatever are defined, auto-indentation always adds 3 tabs.

[pthiess]

Reviewed - Move to backlog - card 379.

[peterflynn]

I get 2 tabs after both closing curly braces instead of 3, if this is the only text in the file.

This is a CodeMirror bug that repros outside of Brackets as well. I've filed codemirror/codemirror5#708 to track it.

[peterflynn]

Looks like the CodeMirror bug has been fixed. It might be a while before we can merge though, since there's been a lot of churn in the scrolling code lately. @jdiehl, do you want to verify the fix upstream in the meantime?

[jdiehl]

This works on CodeMirror.net, so I guess it is fixed. Thanks for forwarding this.

[peterflynn]

Reopening -- this won't be fixed in Brackets until we integrate a newer version of CodeMirror

[pthiess]

Marked low priority

[njx]

The worst of this appears to be fixed now that cmv3 is merged--the indentation doesn't "march inward"--but the indentation level of the case statement is too high (it gets indented two tabs worth instead of one, at least when spaces are on). Assigning to me

[njx]

Filed codemirror/codemirror5#1592 on the latter issue.

[fdecampredon]

This is due to the overriding of electricChars on the Editor.
CodeMirror javascript mode double indent every line in a switch statement except the one with case and default at the beginning.
The problem is that in JavaScript Mode the ":" is an electric char (which is not the case of the _checkElectricChars hardcoded RegExp), so in CodeMirror when you type ':' the indentation on case or default lines are updated, what does not happen in brackets.
I guess a simple fix would be to include the ":" in the _checkElectricChars methods. (in fact does this _checkElectricChars methods could be removed ?)

[njx]

Low pri but nominating for Brackets 1.0 - it looks like a fix should be possible or easy now (an option was added to CM, and also there's @fdecampredon's note).

[njx]

Reviewed. Timebox to half hour.

[peterflynn]

Unfortunately the CM flag added in codemirror/codemirror5#1592 doesn't really help the issue -- it just makes CM insist on intending switch statements completely flat, so things under case aren't indented another stop. And if you manually hit tab on the line under a case, CM will yank the indent level back one every time you hit Enter :-(

It sounds like the real fix is to have _checkElectricChars() trigger on :, but there are several wrinkles there:

• We probably don't want it in languages other than JS (e.g., typing ":" in the middle of HTML text causing indent to shift around would be weird).
• We may not want it in non-switch contexts even in JS (e.g. typing an object literal). This seems like the hardest bit to solve, so hopefully it doesn't turn out to be an issue.
• The current _checkElectricChars() exits early if the electric char isn't the first non-whitespace char on the line. We can't do that in this case because the switch <value> part comes before the :.

[peterflynn]

It also still seems like a bug in CM that the initial line after switch () { is double-indented though, because there's basically no situation where you'd put stuff before the first case statement (and if you did, e.g. some top-level comment, you probably wouldn't want it double-indented either).

[dangoor]

Remove 1.1 milestone. We'll take another look at this when we review Marcel's pull request.

[prafulVaishnav]

Fixed by PR #9387 Closing it.