Migrate brackets shell to 2017

[navch]

Any plans to migrate brackets-shell to vs 2017, I tried to do so but I am facing problems with 2017 compiler. If we can upgrade, then we can make use of beautiful features like Control Flow Guard and Qspectre offered by VS2017 to secure our app.

tagging @nethip @petetnt @swmitra @vickramdhawal

[nethip]

@navch Thanks for taking this up. Can you tell us what issues you are facing with the compiler upgrade?

[vickramdhawal]

I had started work on it once but could not complete it. I was able to get it building after i did some changes manually in addition to changes in script and could not put in enough effort to build it from scratch through a script.
Can i see the effort on a branch ? Maybe, i can help further.

[navch]

First of all, I have one doubt like we have an old version of gyp? Will that be able to generate a solution file for vs 2017? As gyp is no longer maintained. If we can do that using same gyp module then I guess I can do rest of stuff. Please have a look in file brackets-shell/gyp/pylib/gyp/MSVSVersion.py

The last update in gyp is 6 months ago, by looking at this, It looks like this supports vs2017 to some extent but not completely.

[vickramdhawal]

I tried making changes to MSVSVersion.py. Can you refer to https://github.com/adobe/brackets-shell/commits/vdhawal/DebugBuildFix and continue there.
This branch also contains a debug build fix for Mac.

[navch]

Thanks, sir :) This looks very helpful.

[navch]

Hi @vickramdhawal
I upgraded gyp (https://chromium.googlesource.com/external/gyp/+/master) to commit 4d467626b0b9f59a85fb81ca4d7ea9eca99b9d8f in my branch (https://github.com/adobe/brackets-shell/tree/navc/gypupgrade)

Now building via Visual studio(Automatically picks right compiler) works perfectly fine. I will pick your changes for command line build. I will raise a PR asap.