Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Quick Edit Loses Focus when Save Key Commands are Pushed #1556

Closed
ryanstewart opened this issue Sep 5, 2012 · 3 comments
Closed

Quick Edit Loses Focus when Save Key Commands are Pushed #1556

ryanstewart opened this issue Sep 5, 2012 · 3 comments

Comments

@ryanstewart
Copy link
Contributor

I often work this way:

  1. Select a class
  2. Open quick edit
  3. Make changes, test with live preview
  4. Save with key combo (Command+S)
  5. Close Quick Edit (Command+E)

The problem is that as soon as I push Command+S, I my quick edit window loses focus. That means I need to move my mouse and manually move back into Quick Edit.

As a user I would expect either:

  • Command+S to save my CSS file and close quick edit
    or
  • Command+S would not cause my quick edit window to lose focus

I'm happy to work on this fix but want to get feedback on which of those options is best.

@peterflynn
Copy link
Member

The second suggestion (don't lose focus, leave inline open) is the desired behavior.

This is a dupe of #547 and #301, which have been turned into two user story cards:

I believe the focus problem with Save was split out into a separate card because the common case of it seems much easier to fix than the general focus management problem -- essentially, if we didn't open any dialogs as a result of the Save, then we shouldn't touch the focus at all. Restoring focus if a dialog were opened is the tricky bit, but it's also wayyy less common.

@pthiess
Copy link
Contributor

pthiess commented Sep 11, 2012

Reviewed - duplicate - see comments above, closing.

@pthiess pthiess closed this as completed Sep 11, 2012
@pthiess
Copy link
Contributor

pthiess commented Sep 11, 2012

@ryanstewart Please add a vote on the trello cards Peter mentioned.

Keep focus in inline editor after saving changes
Focus Management problems

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants