Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Inline editor fails to scroll into view after focusedEditorChange fixes #1776

Closed
jasonsanjose opened this issue Oct 5, 2012 · 1 comment · Fixed by #1800
Closed

Inline editor fails to scroll into view after focusedEditorChange fixes #1776

jasonsanjose opened this issue Oct 5, 2012 · 1 comment · Fixed by #1800
Assignees

Comments

@jasonsanjose
Copy link
Member

After the fixes for #1257 (in pull #1765) for focusedEditorChange, inline editors opened near the bottom of the window no longer scroll into view.

I attempted to debug in EditorManager _openInlineWidget and for some reason this bug does not reproduce when debugging:

function _openInlineWidget(editor) {
...
  inlinePromise.done(function (inlineWidget) {
    editor.addInlineWidget(pos, inlineWidget); // SET BREAKPOINT HERE!
    PerfUtils.addMeasurement(PerfUtils.INLINE_EDITOR_OPEN);
    result.resolve();
...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant