Find in Files results header messed up after file rename

[peterflynn]

1. Right-click a folder > Find In...
2. Run any search query
3. Leave the results pane open, and rename any file

Result:
Results pane header changes to say "undefined" as the search query and the part of the label indicating the subfolder ("in ...") disappears.

Expected:
Results pane header doesn't change at all.

[peterflynn]

This happens because _fileNameChangeHandler() calls _showSearchResults() with 1 argument when it now expects 3.

I noticed two other bugs in FindInFiles.js, one related and one unrelated, that we should fix at the same time:

• _fileNameChangeHandler() uses the buggy rename-updating logic that ProjectManager ditched in pulls Fix rename issue 2348 #2395/Fix bug #2418 (Renaming unusual filenames leaves UI in inconsistent state) #2420. We should probably centralize that RegExp logic and scrub to make sure all rename handlers are using it instead of the buggier simple RegExp.
• _showSearchResults() needs to escape query where it's used in the big StringUtils.format() block -- otherwise searching on things like "<div" will break the header's formatting.

[pthiess]

@redmunds - Hi Randy, usually I would have opened this to Glenn, but he seems bussy with the Native Menu story. @gruehle and @peterflynn know the code and can help you if needed.

[redmunds]

@peterflynn The _fileNameChangeHandler() receives the entire file path of the file name change. This will only be a problem if the new file name matches an old folder path, which doesn't seem possible. I also opened #2551 about a folder renaming problem that goes beyond the scope of the Find in Files panel.

[redmunds]

Closed (again).