Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Move the comment functions from EditorCommandHandlers to EditorCommentHandlers #3249

Closed
TomMalbran opened this issue Mar 26, 2013 · 4 comments

Comments

@TomMalbran
Copy link
Contributor

EditorCommandHandlers, is getting big, and will keep growing and the the test file is huge, making it hard to work with and to test the tests, so I would suggest to move all the comment functions into a new file EditorCommentHandlers and the tests too since those are what are using most of the space right now.

@ghost ghost assigned TomMalbran Mar 26, 2013
@gruehle
Copy link
Member

gruehle commented Mar 26, 2013

Reviewed -- good suggestion!

@peterflynn
Copy link
Member

Two suggestions:

  1. Also split EditorCommandHandlers-test, which is 4x even more huge
  2. Instead of EditorCommentHandlers, how about something like ToggleComment or CommentUncomment? The "Editor"/"Handler" prefix/suffix are pretty generic and don't seem that necessary.

@peterflynn
Copy link
Member

We should wait for #3060 and possibly the token stream stuff to land before doing this -- otherwise the merge conflicts will be a nightmare.

@TomMalbran
Copy link
Contributor Author

  1. Yes, the split would split the test files too following the same split as the EditorCommandHandlers, leaving all the comment tests in one test file and the rest in the original file.
  2. I like the ToggleCommentHandlers name, CommentUncommentHandlers is a bit too long, or you referring without the handlers suffix in the name?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants