Start with the following code:
2 - code hints pop up listing all HTML entities
3 - entity hints remain visible; there is no sign of the list being filtered down at all
4 - same entity hints pop up again
5 - no code hints appear
6 - same entity hints pop up again
2, 3, 4 - no code hints
5, 6 - HTML tag code hints pop up
@WebsiteDeveloper @redmunds I'm assuming this broke due to #3237.
In addition to a fix, we should add a couple of unit tests in this area.
I would question whether SpecialCharHints should have anything other than "&" in its trigger keys. In other words, unless implicitChar is null or "&", hasHints() should always return false. This also avoids the added compute cost of calling _getQuery() on virtually every keystroke while editing HTML.
the problem is, that removing all the trigger keys except "&" does show hints when "&" is typed but when one types "&a" then no hints are displayed anymore. I'll look into it and also add a few unit tests.
I'm seeing a few other problems with this extension. Let me know if you prefer I break these out into separate bugs:
please split those up i already have a fix for the cases mentioned in this bug.
FBNC back to @peterflynn. All of the "few other problems" seem to be fixed for me as well. I think the last bullet (only replacing part of existing entity) should be fixed in this sprint, but the exceptions can be split off into a separate bug. Should probably also open a bug for the unit tests.
@RaymondLim do you have cycles to verify this one? You know more about code hinting functionality than I do anyway :-)
Feel free to reassign back to me if you're overbooked though
Added some more unit tests + cleanup fixes