[JS code hints] Prefer results that match case of the query string

[iwehrman]

[njx]

Reviewed, to @dloverin. Please assign a priority. Thanks!

[dangoor]

Assigning to myself, medium priority.

[lkcampbell]

@dangoor, I submitted a fix and assigned this bug to myself. I assume (and hope) that you will be doing the review.

[dangoor]

@lkcampbell I'll be happy to review! Timing-wise we'll likely need to land this next sprint, but I'll take a look.

[lkcampbell]

I'm closing that previous PR. Going to try out a different approach this week.

[lkcampbell]

@dangoor, I apologize but I am going to have to withdraw from fixing this bug and assign it back to you. I tried to work my way through the string matching algorithm but I am having a difficult time understanding all the pieces, and I am concerned I would do more harm than good if I muck around with it.

[dangoor]

@lkcampbell Yeah, sorry about that... StringMatch is pretty much my fault. I wrote a blog post about it, but that doesn't reduce the complexity any.

It has lots of tests, so you don't really need to worry about doing harm. But, I totally understand not wanting to unravel what that code does.

[peterflynn]

Reviewed - agree with 1.0

[peterflynn]

@dangoor What do you think about splitting off just the Function / function issue as a special case in the JS code hints code? That should be a super easy fix to get in for 1.0 and fixes the most visible part of this. Then the larger, broader-reaching StringMatch changes could be tracked by #2663 for fixing post-1.0...

[dangoor]

@peterflynn I'll keep that thought in mind when looking at this. I may take a small timeboxed look at stringmatch because there have been other times when I wished it matched cases. If it looks like it will take too long, I'll just make a change in JS code hints.

[dangoor]

This is now fixed on master. woohoo!

FBNC to @iwehrman

[marcelgerber]

Finally!

[marcelgerber]

Btw, #3263 is a dupe of this issue that can be closed as well.

[le717]