Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][Search Result Panel]: The search result title is truncated if find a long string in project. #4602

Closed
julieyuan opened this issue Jul 30, 2013 · 9 comments

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets.
  2. Select a long line string and to press shortcut Ctrl+Shift+F to find this string in project.
  3. Press Enter , then search result will appear on the bottom of Brackets.

Result:
The search result title is truncated, and can not close the panel.

Expected:
All strings display well.

ENV: MAC 10.8.3 and Win8.1 English OS
Build: 0.28.0-8528

Snapshot:
Please refer to snapshot for details:
screen shot 2013-07-29 at 11 25 53 pm

@jasonsanjose
Copy link
Member

Reviewed. Starter bug. Should be easy to fix the layout, use CSS to add ellipsis, add a tooltip, and confirm that the close X button is still visible and clickable.

@zaggino
Copy link
Contributor

zaggino commented Aug 5, 2013

@jasonsanjose Not that easy, I tried - ellipsis is already there, layout of the search results probably has to be modified to solve this. I managed to get the close button always visible, but failed to trigger the CSS ellipsis on the text itself ...

@zaggino
Copy link
Contributor

zaggino commented Aug 6, 2013

Finally managed to even trigger ellipsis with a few changes to the layout.
image

@TomMalbran
Copy link
Contributor

FBNC @julieyuan

@ghost ghost assigned julieyuan Aug 22, 2013
@julieyuan
Copy link
Author

Thanks. Changes haven't been merged into latest build 0.30.0-8837 yet. Will check it in next build.

@julieyuan
Copy link
Author

Not fixed in latest build 0.30.0-8873. Similar issue with #4870. Thanks for your efforts and sorry for it is still happening...Here is the snapshot for reference:
capture dcran 2013-08-25 19 06 35

@ghost ghost assigned TomMalbran Aug 26, 2013
@TomMalbran
Copy link
Contributor

Both issues where fixed using flex-box and they both work with the Sprint 29 shell but are broken in the new Sprint 30 shell. Something with the new version of chrome used in the latest shell broke this. Will see if I can fix it.

@TomMalbran
Copy link
Contributor

FBNC again. @julieyuan can you test it please?

@ghost ghost assigned julieyuan Sep 6, 2013
@julieyuan
Copy link
Author

Fixed in build 0.31.0-9351. Great Job! Here is the snapshot:
screen shot 2013-09-10 at 12 03 47 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants