Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Code hints should filter out unlikely matches #5993

Open
dangoor opened this issue Nov 14, 2013 · 4 comments
Open

Code hints should filter out unlikely matches #5993

dangoor opened this issue Nov 14, 2013 · 4 comments

Comments

@dangoor
Copy link
Contributor

dangoor commented Nov 14, 2013

This was suggested on IRC: document.g shouldn't show things like height. JS code hints use the StringMatch algorithm. StringMatch needs to match things across a whole path, whereas code hints are really only matching the equivalent of a single "segment" of a path. Because of this, it's reasonable to expect that the first letter should always be a match.

@pthiess
Copy link
Contributor

pthiess commented Nov 14, 2013

@dangoor Is that a move to backlog or a small effort issue?

@ghost ghost assigned dangoor Nov 14, 2013
@dangoor
Copy link
Contributor Author

dangoor commented Nov 14, 2013

Small effort. Low priority to me.

@peterflynn
Copy link
Member

@dangoor Maybe don't filter it out if the first letter matches a 'special' though? You could imagine someone using an API with prefixes (e.g. in native code you see this a lot: NS* on Mac, gl* in for OpenGL, etc.) to want hints to match stuff without having to type the prefix.

@dangoor
Copy link
Contributor Author

dangoor commented Nov 15, 2013

Yeah, good suggestion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants