This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Disallow Empty Exclusion Sets #7961
Milestone
Comments
Found while testing the feature on Windows in Pull Request #7836. @njx @RaymondLim IMHO, this is probably low priority since it's mostly cosmetic. |
We may have to disable the OK button since we also need to take care of editing an existing exclusion set where we can't silently dismiss the dialog when the user empty the filter set. |
FBNC to @bchintx |
Works great! Thanks! @RaymondLim and @SAplayer |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Could we consider disallowing empty Exclusion Set entries from being created? Since there's already a fixed "Don't Exclude Files" menu item in the Exclusion Set dropdown list, empty set entries are redundant. Plus, they look odd in the dropdown menu.
Steps to reproduce:
Observed:
blank line in the dropdown menu
Expected:
perhaps consider not allowing the empty set to be created by the Edit Exclusion Set dialog? maybe disable the OK button or just don't create anything if they click OK?
The text was updated successfully, but these errors were encountered: