Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Disallow Empty Exclusion Sets #7961

Closed
bchintx opened this issue May 28, 2014 · 4 comments
Closed

Disallow Empty Exclusion Sets #7961

bchintx opened this issue May 28, 2014 · 4 comments
Assignees
Milestone

Comments

@bchintx
Copy link
Contributor

bchintx commented May 28, 2014

Could we consider disallowing empty Exclusion Set entries from being created? Since there's already a fixed "Don't Exclude Files" menu item in the Exclusion Set dropdown list, empty set entries are redundant. Plus, they look odd in the dropdown menu.

emptyexclusionsetname

Steps to reproduce:

  1. launch Brackets and open any project
  2. + + F to display the Find in Project bar
  3. Click the Exclusion Set dropdown button.
  4. Click "New Exclusion Set..."
  5. in the resulting dialog, just click OK without entering any exclusions or name.
  6. Click the Exclusion Set dropdown button again.

Observed:
blank line in the dropdown menu

Expected:
perhaps consider not allowing the empty set to be created by the Edit Exclusion Set dialog? maybe disable the OK button or just don't create anything if they click OK?

@bchintx
Copy link
Contributor Author

bchintx commented May 28, 2014

Found while testing the feature on Windows in Pull Request #7836.

@njx @RaymondLim IMHO, this is probably low priority since it's mostly cosmetic.

@RaymondLim
Copy link
Contributor

We may have to disable the OK button since we also need to take care of editing an existing exclusion set where we can't silently dismiss the dialog when the user empty the filter set.

@RaymondLim
Copy link
Contributor

FBNC to @bchintx

@bchintx
Copy link
Contributor Author

bchintx commented May 29, 2014

Works great! Thanks! @RaymondLim and @SAplayer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants