Deleting a file shows no confirm dialog

[Mark-Simulacrum]

Even if files can be retrieved from the trash bin, this seems like something that should at least be optional. I often accidentally click delete when attempting to rename a file, which causes me to have to either go find the file in trash (which often takes up 5 minutes or so of time) or to restore it from Git (if I am in a Git repository).

I am not really sure how Brackets will handle a file system without a trash location (read only discs, file shares, USB drives often have this), it seems safer to just open up a (optional) dialog to ask the user if they really want to delete the file.

[pthiess]

@Mark-Simulacrum I think solving this via a preference for confirmation is a good idea. We haven't heard other complains about this yet, hence this seems a lower priority.

[marcelgerber]

Good hint about the no-trash case.
I just tested it with an USB stick (Win 8.1), deleted a file and boom... no confirm prompt, no recovery oppurtunity. Forever away.

[ingorichter]

@marcelgerber but I still believe that this is an edge case that no-trash is available. At least for the majority of our users. I wonder what happens in your case when you try to install an extension. Where does the appdata folder get's written to? Or does Windows keep an in-memory filessystem for some basic operations to work? Just curious. ;-)

[marcelgerber]

@ingorichter Well, it's not too much of an edge case. Windows has its trash management only for hard drives, and while I'm not sure about network drives (but I guess they have to handle trash themselves), USB sticks don't have one.
So if you open a USB sticks directory in Brackets, everything you delete won't be undoable.

And nope, Brackets is still installed the normal way (not a portable build or such) and therefore, extensions are still located on the hard drive.

[boakley]

Personally I hate confirm dialog boxes. Imagine if you needed to delete 20 files. click confirm click confirm click confirm ... Plus, nobody actually reads confirm dialogs.

I'd much rather see you simply move the delete and rename items further apart to make accidental delete considerably less likely. That is much simpler to implement, and is at least arguably a little more user friendly.

[Mark-Simulacrum]

I don't think moving the options away from each other is a complete solution, but it is a start. The confirm dialog would be by default disabled, although I would recommend showing it at least once (first file deletion).

[wilfm]

I am trying out Brackets (very good so far :), but find it odd that the delete function has no prompt, and moves any files 'deleted' to trash with no questions asked (but does prompt for folders... ?)

Would it be possible to build a extension to do this, or are extensions not allowed to manage this functionality? (I am guessing from looking at the pull request that it has to be compiled in from source).

Using Brackets 1.3 - Built from source (this morning - don't want to do it again today.....), Fedora 21 (Linux) x86_64

[marcelgerber]

A Confirm dialog is now shown when deleting a file.
Closing.