Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove axe violation while using inline icons #159

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix: remove axe violation while using inline icons #159

merged 1 commit into from
Mar 12, 2021

Conversation

Pareesh
Copy link
Collaborator

@Pareesh Pareesh commented Mar 12, 2021

There were two same icons present in spectrum-icons.svg with same id, which lead to axe violation.
Id was : 'spectrum-icon-24-StartConversion'

Description

removed the extra icon present in spectrum-icons.svg

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@CezCz CezCz closed this Mar 12, 2021
@CezCz CezCz reopened this Mar 12, 2021
@CezCz CezCz merged commit 41cbd00 into adobe:master Mar 12, 2021
github-actions bot pushed a commit that referenced this pull request Mar 12, 2021
## [4.10.16](v4.10.15...v4.10.16) (2021-03-12)

### Bug Fixes

* remove axe violation while using inline icons ([#159](#159)) ([41cbd00](41cbd00))
@github-actions
Copy link

🎉 This PR is included in version 4.10.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants