fix(GRANITE-32443): Add min property in coral-multifield component
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 3, 2021 23:59
@remove unnecessary changes
Pareesh
changed the title
min property in coral-multifield component
added 3 commits
April 5, 2021 18:26
|
The failing test case does not relates to the changes |
@add empty code to trigger build
majornista
approved these changes
Apr 20, 2021
indra2gurjar
approved these changes
Apr 23, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Apr 23, 2021
## [4.10.19](v4.10.18...v4.10.19) (2021-04-23) ### Bug Fixes * **GRANITE-32443:** Add `min` property in coral-multifield component ([#162](#162)) ([819a6b4](819a6b4))
|
🎉 This PR is included in version 4.10.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support where consumer wants to shows at least n multifield items.
Description
This PR adds a min property to coral-multifield component. This will be used if a consumer wants to display atleast n-items. If the coral-mulltifield component contains items less than specified min value, the remaining empty items will added. The validation will be done when component is connected to DOM tree, this is done to avoid unnecessary addition of items resulting if will validate on construct.
Related Issue
GRANITE-32443
Review
@review @icaraps @CezCz @majornista
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: