fix: remove duplicate path ids from spectrum-icons.svg #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix com.adobe.granite.ui.it.e2e Selenium test failure: https://jenkins-sprouts.bsl.eur.adobe.com/blue/organizations/jenkins/Granite_com.adobe.granite.ui.coral-spectrum/detail/PR-86/1/tests Related issues: https://jira.corp.adobe.com/browse/GRANITE-33028 and adobe#173.
|
@Pareesh can you please review this? |
github-actions bot
pushed a commit
that referenced
this pull request
May 25, 2021
## [4.10.23](v4.10.22...v4.10.23) (2021-05-25) ### Bug Fixes * remove duplicate path ids from spectrum-icons.svg ([#175](#175)) ([563ca0d](563ca0d))
|
🎉 This PR is included in version 4.10.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should fix Selenium test failures:
Related issues: https://jira.corp.adobe.com/browse/GRANITE-33028 and #173.
Related Issue
Motivation and Context
Automated accessibility testing will report an error message when there are one or more duplicate ids in a document. In some cases, as with "spectrum-icon-24-StartConversion" a symbol may be duplicated in the svg, while elsewhere, as with paths with
id="_256", SVG editing software might generate an id for a path, and if the path is then copied to another symbol, the id might be duplicated.How Has This Been Tested?
Tested using aXe Chrome extension against /coral-component-icon/examples/index.html
Screenshots (if appropriate):
Types of changes
Checklist: