fix(SITES-1579): Role and state are not narrated for the TABS in the create page while navigating in the browse mode using down arrow. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to test timeouts
issue/SITES-1579/Wait a frame for layout and adjust timing to conform to test timeouts
majornista
approved these changes
Sep 2, 2021
Pareesh
reviewed
Sep 2, 2021
Pareesh
reviewed
Sep 2, 2021
Pareesh
reviewed
Sep 2, 2021
Pareesh
reviewed
Sep 2, 2021
Pareesh
reviewed
Sep 2, 2021
Pareesh
reviewed
Sep 2, 2021
Pareesh
reviewed
Sep 2, 2021
6 tasks
issue/SITES-1579/Updates per code review
Pareesh
approved these changes
Sep 6, 2021
majornista
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
## [4.11.1](v4.11.0...v4.11.1) (2021-09-08) ### Bug Fixes * **SITES-1579:** Role and state are not narrated for the TABS in the create page while navigating in the browse mode using down arrow. ([#183](#183)) ([32c9c88](32c9c88))
|
🎉 This PR is included in version 4.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added hidden element with aria live region visible to screen readers, so JAWS can announce the state.
Related Issue
Issue: https://jira.corp.adobe.com/browse/SITES-1579
Motivation and Context
JAWS doesn't announce the selected/unselected state of the masonry item with role="gridcell".
How Has This Been Tested?
Manually and with unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: