Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CQ-4340781): Blank screen for view Page Properties - Coral Tab not being selected #197

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Conversation

Pareesh
Copy link
Collaborator

@Pareesh Pareesh commented Feb 4, 2022

…eing selected

When loading the properties page in aem, sometimes the coral-panelstack does not gets selected. This results in a blank page. This issue seems to be coral-panelstack getting constructed twice and the newer constructed panelstack replaces the old created panelstack but the tablist target has already been set to the older one.

Description

The change is a workaround to sync the tablist target with new panelstack and update the selection.

Related Issue

https://jira.corp.adobe.com/browse/CQ-4340781

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Pareesh Pareesh changed the title CQ-4340781 : Blank screen for view Page Properties - Coral Tab not be… fix(CQ-4340781): Blank screen for view Page Properties - Coral Tab not being selected Feb 7, 2022
@Pareesh Pareesh merged commit 9615b03 into adobe:master Feb 7, 2022
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
## [4.12.6](v4.12.5...v4.12.6) (2022-02-07)

### Bug Fixes

* **CQ-4340781:** Blank screen for view Page Properties - Coral Tab not being selected ([#197](#197)) ([9615b03](9615b03))
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

🎉 This PR is included in version 4.12.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants